fix: add support for name attributes in HTML fragment extraction #1839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes fragment checking for JavaDoc-generated HTML which uses <a name="anchor"> instead of id attributes for anchors. This resolves a regression where lychee v0.20.1 was failing to find fragments that worked in v0.18.1, particularly for JavaDoc URLs like: - https://example.com/javadoc/Class.html#method-- - https://example.com/javadoc/Class.html#skip.navbar.top The fix maintains backward compatibility by checking both 'id' and 'name' attributes when extracting fragments from HTML documents. Resolves #1838
thomas-zahner
approved these changes
Sep 6, 2025
| } | ||
|
|
||
| // Also check for 'name' attributes for backward compatibility with older HTML | ||
| // standards and JavaDoc-generated HTML which uses <a name="anchor"> instead of id |
There was a problem hiding this comment.
Maybe you could add: https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/a#name or https://stackoverflow.com/a/484781
So apparently in HTML 4.01it both could be used. Theoretically, it's no longer valid HTML 5, but it's still used by some tools/sites because of historical reasons.
There was a problem hiding this comment.
Ah, neat. I've extended the documentation accordingly.
Closed
This was referenced Oct 21, 2025
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes fragment checking for JavaDoc-generated HTML which uses instead of id attributes for anchors.
This resolves a regression where lychee v0.20.1 was failing to find fragments that worked in v0.18.1, particularly for JavaDoc URLs like:
The fix maintains backward compatibility by checking both 'id' and 'name' attributes when extracting fragments from HTML documents.
Resolves #1838