Skip to content

Conversation

@thomas-zahner
Copy link
Member

Document the new preprocessor feature.
Ideally, we should only merge this with the next lychee release to prevent confusion by users.

@thomas-zahner thomas-zahner force-pushed the file-preprocessing branch 4 times, most recently from 9bc1f12 to 538f721 Compare November 6, 2025 22:05
@thomas-zahner
Copy link
Member Author

I've now worked around the regex size error that occurs on all new PRs. In the process I greatly simplified the link checking. (see last 3 commits) I'm now simply checking all links instead of only the new ones. As we seem to use a pretty fast link checker this seems to be no problem and the step completes in ~5 seconds. 🙃

So I see no good reason to stick to this overly complicated approach of only checking additions.Also I noticed that the src directory wasn't checked previously. In total the workflow should be faster because we have much fewer steps and we don't build twice.

Copy link
Member

@mre mre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this is really high quality work. You managed to significantly simplify the workflow. Good job! Also, thanks for following the boyscout rule and cleaning up the ignore file.

@mre mre merged commit 5655db7 into master Nov 7, 2025
2 checks passed
@mre
Copy link
Member

mre commented Nov 7, 2025

As a side note, I'm amazed at how fast lychee is. 5 seconds for the link check is amazing. Most of it is thanks to Rust and its ecosystem, of course. And fast servers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants