[BATCHCMP-379] Support subdirectory reads #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 984bf78)
anuvedverma
force-pushed
the
BATCHCMP-379-support-subdirectory-reads
branch
from
c60b6f9 to
dcd8c6d
Compare
anuvedverma
force-pushed
the
BATCHCMP-379-support-subdirectory-reads
branch
from
dcd8c6d to
4d917dc
Compare
Legal RiskThe following dependencies were released under a license that RecommendationWhile merging is not directly blocked, it's best to pause and consider what it means to use this license before continuing. If you are unsure, reach out to your security team or Semgrep admin to address this issue. EPL-1.0
EPL-2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 984bf78)
Brings Spark 3.3 patch #40 into our Spark 3.5 fork, with a couple small modifications:
spark.sql.sources.readPartitionWithSubdirectory.enabledtofalseby default (then set totruein spark wrapper https://github.com/lyft/spark-private/pull/1575)listLeafDirStatusesandlistLeafDirStatusesfromSparkHadoopUtil.scala-- this PR brings them back for our forkThis patch is needed because there are a large number of tables with nested subdirectories (eg. most tables under
featureschema, generated by featureservice) -- see thread for more context.Eventually, we want to fix underlying tables that rely on nested subdirectories, and get rid of this patch & config entirely. But fixing these tables will take a longer dedicated effort. Created backlog ticket BATCHCMP-459 for this effort in the future.