Skip to content

Add delete nodes #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 25, 2017
Merged

Add delete nodes #68

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
97a01a3
added delete, thinking about moving to onDelete prop
mac-s-g Jun 19, 2017
cef112b
stable delete and edit separated, preserving undefined
mac-s-g Jun 19, 2017
07861fe
demo-ready, not fully functional
mac-s-g Jun 21, 2017
b362600
added onAdd, onDelete
mac-s-g Jun 24, 2017
230a5d9
update
mac-s-g Jun 24, 2017
6d19571
update
mac-s-g Jun 24, 2017
c413d69
update
mac-s-g Jun 25, 2017
d6e0c5e
update docs
mac-s-g Jun 25, 2017
1fb9129
update
mac-s-g Jun 25, 2017
7c86716
updated tests
mac-s-g Jun 25, 2017
23976bc
added-tests
mac-s-g Jun 25, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update
  • Loading branch information
@mac-s-g
mac-s-g committed Jun 25, 2017
commit c413d695c506ea3dd2c97354a6c9568d23f12596
11 changes: 0 additions & 11 deletions src/js/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,17 +111,6 @@ export default class extends React.Component {
message: 'src property must be a valid json object'
}
}

//make sure `onEdit` prop is a function when not `false`
if (this.state.onEdit !== false
&& toType(this.state.onEdit) !== 'function'
) {
this.state.onEdit = ()=>{};
console.error(
'react-json-view error:',
'onEdit property must be a function when enabled'
);
}
}

render() {
Expand Down