Implemented checkbox #24
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@bdlukaa pull the latest changes from dev |
Closed
GroovinChip
requested changes
Apr 17, 2021
GroovinChip
requested changes
Apr 18, 2021
Collaborator
GroovinChip
left a comment
GroovinChip
left a comment
There was a problem hiding this comment.
The checkbox is not visible in light theme.
Use the spec from the Figma kit to ensure the UI is correct in each theme
GroovinChip
requested changes
Apr 18, 2021
GroovinChip
requested changes
Apr 19, 2021
Contributor
Author
|
@GroovinChip I think it's better to create a new pr, after this and the others get merged, with the example app updated @bdlukaa oh, for sure. The gallery app can be done after these get merged. That said, I still think it's worth making a combined PR for checkbox and radio button to reduce conflicts |
5 tasks
Contributor
Author
|
Closing as duplicate of #47 |
Closed
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.