Skip to content

Fix for invalid dates #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GroovinChip merged 2 commits into from
Mar 31, 2023
Merged

Fix for invalid dates #402

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
651488e
Fix for invalid dates
eliasyishak Mar 31, 2023
afdcebd
Update pubspec.yaml
eliasyishak Mar 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
## [1.12.4]
* Default the `_selectedDay` state variable to be 1 when selecting the previous/next month from widget to ensure new date is valid for `_formatAsDateTime()` method (https://github.com/flutter/flutter/issues/123669 & https://github.com/macosui/macos_ui/pull/402)

## [1.12.3]
* Added support for `routerConfig` to `MacosApp.router`. ([#388](https://github.com/macosui/macos_ui/issues/388))

Expand Down
12 changes: 10 additions & 2 deletions lib/src/selectors/date_picker.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,9 +354,13 @@ class _MacosDatePickerState extends State<MacosDatePicker> {
setState(() {
_selectedYear--;
_selectedMonth = 12;
_selectedDay = 1;
});
} else {
setState(() => _selectedMonth--);
setState(() {
_selectedMonth--;
_selectedDay = 1;
});
}
widget.onDateChanged.call(_formatAsDateTime());
},
Expand Down Expand Up @@ -397,9 +401,13 @@ class _MacosDatePickerState extends State<MacosDatePicker> {
setState(() {
_selectedYear++;
_selectedMonth = 1;
_selectedDay = 1;
});
} else {
setState(() => _selectedMonth++);
setState(() {
_selectedMonth++;
_selectedDay = 1;
});
}

widget.onDateChanged.call(_formatAsDateTime());
Expand Down
2 changes: 1 addition & 1 deletion pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: macos_ui
description: Flutter widgets and themes implementing the current macOS design language.
version: 1.12.3
version: 1.12.4
homepage: "https://macosui.dev"
repository: "https://github.com/GroovinChip/macos_ui"

Expand Down