Alter copy of mock_canvas to unblock moving to flutter_test #467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
8 tasks
Collaborator
|
Amazing! Thank you, Kate! |
Piinks
added a commit
to flutter/tests
that referenced
this pull request
Jul 31, 2023
Updates commit for macosui/macos_ui#467 which unblocks flutter/flutter#131631
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Came up as a test failure in flutter/flutter#131631
Since mock_canvas was copied into this repo, the analysis will fail when we try to make it public. This just renames the methods so we can land the change. Once it is part of flutter_test, the copy of recording_canvas and mock_canvas can be removed entirely since it will be public.
The commit in flutter/tests will need to be updated after this for the PR in flutter/flutter to be able to land.
Pre-launch Checklist
CHANGELOG.mdwith my changes