Skip to content

Integration test data fixture change proposal #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Integration test data fixture change proposal #373

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c702b96
Proposal for reusable and customizable data fixtures
bubasuma Apr 23, 2020
81d9d5e
Proposal for reusable and customizable data fixtures
bubasuma Apr 27, 2020
ab892ec
Replace comma with space for consistency with other fixture annotations
bubasuma Apr 27, 2020
4371ad8
Correct typo
bubasuma Apr 27, 2020
c16ef3d
Replace the json format with a new format that allows resolving depen…
bubasuma May 21, 2020
d7a7ee7
Fix grammar
bubasuma Jun 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Replace comma with space for consistency with other fixture annotations
  • Loading branch information
@bubasuma
bubasuma committed Apr 27, 2020
commit ab892ec206bdbcdebfafc5497ddd8b1e12763a2e
4 changes: 2 additions & 2 deletions design-documents/testing/integration/data-fixtures.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,11 @@ We could certainly redesign data fixtures to be object oriented. But if we just
to support a second parameter which will be injected to the data fixture file as following.
```php
/**
* @magentoDataFixture Magento/Catalog/_files/product_virtual.php, {"productData":{"stock_data": {"qty":1}}}
* @magentoDataFixture Magento/Catalog/_files/product_virtual.php {"productData":{"stock_data": {"qty":1}}}
*/

```
The string after comma following the fixture file name is indeed the data that needs to be injected into the fixture file for customization. The format is well known JSON format that gives a flexible way to pass any type of data to the fixture (string, int, float and array).
The string following the fixture file name is indeed the data that needs to be injected into the fixture file for customization. The format is well known JSON format that gives a flexible way to pass any type of data to the fixture (string, int, float and array).

```php
use Magento\TestFramework\Catalog\Model\ProductFixtureFactory;
Expand Down