Skip to content

GraphQL schema for dynamic blocks #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
melnikovi merged 4 commits into from
Oct 22, 2020
Merged

GraphQL schema for dynamic blocks #451

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bb14b03
GraphQL schema for dynamic blocks
melnikovi Oct 8, 2020
6547dbd
Minor updates
melnikovi Oct 20, 2020
0f8c22b
Add pagination back and change type of the content field
melnikovi Oct 22, 2020
b3e9d8e
Remove name field from example
melnikovi Oct 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Minor updates
  • Loading branch information
@melnikovi
melnikovi committed Oct 20, 2020
commit 6547dbd71d11c3f31c890ad1fbbb0c0542fdf726
13 changes: 3 additions & 10 deletions design-documents/graph-ql/coverage/dynamic-blocks.graphqls
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,26 +1,19 @@
type DynamicBlock {
uid: ID!
name: String!
content: String!
Copy link
Member Author

@melnikovi melnikovi Oct 8, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can make it ComplexTextValue, that would allow to return content as a JSON in the future.

}

type DynamicBlocks {
items: [DynamicBlock]!
page_info: SearchResultPageInfo
total_count: Int!
}

# We don't need is_enabled, locations, ga_creative, catalog_price_rule_ids, cart_price_rules_ids, locations on storefront
# We don't need name, is_enabled, locations, ga_creative, catalog_price_rule_ids, cart_price_rules_ids, locations on storefront

type DynamicBlocksFilterInput {
type: DynamicBlockTypeEnum!
locations: [DynamicBlockLocationEnum!] # Blocks for all locations will be displayed if not supplied
rotation_mode: DynamicBlockRotationModeEnum!
Copy link

@supernova-at supernova-at Oct 22, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is rotation_mode required?

I don't think the PWA will know this when it is querying.

Copy link
Member Author

@melnikovi melnikovi Oct 22, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This setting allows to request one random dynamic block, multiple dynamic block to display all at once, etc. rotation_mode comes from the data-rotate attribute on the dynamic block node.

Copy link

@supernova-at supernova-at Oct 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, right - ok, thanks!

dynamic_block_uids: [Int!] # Only makes sense when DynamicBlockTypeEnum is set to SPECIFIED
dynamic_block_uids: [ID!] # Only makes sense when DynamicBlockTypeEnum is set to SPECIFIED
}

type DynamicBlocksOutput {
dynamic_blocks: DynamicBlocks!
items: [DynamicBlock]!
}

enum DynamicBlockTypeEnum {
Expand Down