Avoid querying inventory default stock view in storefront operations #2350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Looking for a maintainer to review. |
swnsma
suggested changes
Jul 8, 2019
| $select->from( | ||
| $stockItemTableName, | ||
| [ | ||
| GetStockItemDataInterface::QUANTITY => 'qty', |
Contributor
There was a problem hiding this comment.
Constants may be used
\Magento\CatalogInventory\Api\Data\StockStatusInterface::QTY
\Magento\CatalogInventory\Api\Data\StockStatusInterface::STOCK_STATUS
Contributor
Author
There was a problem hiding this comment.
Solution requires adding a dependency on the CatalogInventory this should be done in a centralized way, so filed a separate ticket for it.
#2387
| GetStockItemDataInterface::QUANTITY => 'qty', | ||
| GetStockItemDataInterface::IS_SALABLE => 'stock_status', | ||
| ] | ||
| )->where('product_id' . ' = ?', $productId); |
Contributor
There was a problem hiding this comment.
I do not see sense to join both stings when you can directly use joined string.
4 tasks
ishakhsuvarov
added a commit
that referenced
this pull request
Nov 22, 2019
Avoid querying inventory default stock view in storefront operations
robertorubino
added a commit
to magento-sparta/inventory-deprecated
that referenced
this pull request
May 21, 2020
robertorubino
added a commit
to magento-sparta/inventory-deprecated
that referenced
this pull request
May 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
This Pull Request is supposed to reduce the usage of
inventory_stock_1database view in frontend operations.Contribution checklist (*)