Fix for wrong coupon calculation. #326
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a missing check wether the item is excluded from discount.
This leads to a wrong calculation of the discount amount here:
https://github.com/magento/magento2/blob/master/app/code/Mage/SalesRule/Model/Validator.php/#L383-384
The reason is, that it calculates the share of the item on the total discount. Since the bug uses the no-discount item to calculate the base items total, the calculated discount is wrong (the no discount item never makes it to the
process()
method, as this takes thenoDiscount
into account).