Skip to content

Remove engines declaration from package.json #1572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Turbo87 merged 1 commit into from
May 19, 2022
Merged

Remove engines declaration from package.json #1572

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Remove engines declaration from package.json 
Since this is not a Node.js package, it does not make sense for us to declare what Node.js version we're compatible with, especially if it means that adjusting the value could be considered a breaking change.
  • Loading branch information
@Turbo87
Turbo87 committed May 19, 2022
commit aa0cecebaa502364c0f5742810899892b2d405bb
3 changes: 0 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,9 +86,6 @@
"typescript": "4.6.4",
"webpack": "5.72.1"
},
"engines": {
"node": "12.* || 14.* || >= 16.*"
},
"changelog": {
"repo": "simplabs/qunit-dom",
"labels": {
Expand Down