Skip to content
This repository was archived by the owner on Mar 31, 2025. It is now read-only.

Conversation

@sunny
Copy link
Contributor

@sunny sunny commented Jan 30, 2023

It is bad practice to require the whole gem and its dependencies inside the gemspec that defines these dependencies 🙃

This is a fix that only requires the version.

@sunny sunny changed the title Gemspec: Do not require the whole gem inside the gemspec 💎 Do not require the whole gem inside the gemspec Jan 30, 2023
@UltiMich UltiMich merged commit a921f17 into makerbot:master Jun 7, 2024
@sunny sunny deleted the do-not-require-gems-in-gemspec branch June 8, 2024 07:19
@sunny
Copy link
Contributor Author

sunny commented Jun 10, 2024

Thanks for the merge \o/

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants