test: Changes for catch2 >3.8#4134
Merged
Merged
Conversation
jjerphan
changed the title
jjerphan
force-pushed
the
test/changes-catch2-gt-3.8
branch
2 times, most recently
from
55318ac to
3cc7965
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4134 +/- ##
==========================================
+ Coverage 4.19% 63.11% +58.92%
==========================================
Files 315 316 +1
Lines 38777 38806 +29
Branches 2996 2986 -10
==========================================
+ Hits 1625 24494 +22869
+ Misses 37149 14241 -22908
- Partials 3 71 +68 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Klaim
approved these changes
Jan 12, 2026
Member
Klaim
left a comment
Klaim
left a comment
There was a problem hiding this comment.
LGTM, very minor suggestions below, you can ignore
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz> Co-authored-by: Ben Mares <services-git-throwaway2@tensorial.com>
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz> Co-authored-by: Klaim <Klaim@users.noreply.github.com>
JohanMabille
approved these changes
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
catch2 3.8 was used but newer versions requires changes, mostly for tests execution as of 3.9.
(The update to catch2 3.12 published yesterday with conda-forge/catch2-feedstock#75 triggered failures on the CI even though other versions between 3.8 and 3.12 have been available for a while on conda-forge.)
Type of Change
Checklist
pre-commit run --alllocally in the source folder and confirmed that there are no linter errors.