fix: Only call get_all_running_processes_info when needed#4135
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4135 +/- ##
=======================================
Coverage 63.11% 63.12%
=======================================
Files 316 316
Lines 38806 38807 +1
Branches 2986 2987 +1
=======================================
+ Hits 24494 24498 +4
+ Misses 14241 14238 -3
Partials 71 71 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jjerphan
reviewed
Jan 13, 2026
Member
jjerphan
left a comment
There was a problem hiding this comment.
Thank you, @mihaitodor.
Indeed get_all_running_processes_info only must be called when needed.
micromamba runget_all_running_processes_info when needed
Contributor
Author
|
@jjerphan Thank you for confirming! I fixed the linter error (should've checked again before pushing). |
Do not call `get_all_running_processes_info()` unless the log level requires printing debug logs. Signed-off-by: Mihai Todor <todor@ebi.ac.uk>
Member
|
I have rebased your PR to have #4137 in. |
JohanMabille
approved these changes
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not call
get_all_running_processes_info()unless the log level requires printing debug logs.When running micromamba in a specific production environment, we keep getting
Segmentation fault (core dumped)and, by adding more logs in the code, I was able to narrow it down to this particular log entry, where it tries to print the currently running processes. I can confirm that the crash doesn't occur inget_all_running_processes_info()and it is something in theMessageLoggerimplementation, but I have a hard time narrowing it down since I don't have access to run gdb in that environment or collect core dumps. I believe it is something to do with the length of the resulting string, but I've not been able to get it to reproduce reliably in a unit test. However, we don't use debug logs and, in this case, I think the code should skip this log clause completely, which should unblock us.Description
Type of Change
Checklist
pre-commit run --alllocally in the source folder and confirmed that there are no linter errors.