Skip to content

maint: Refactor Channel Loader#4169

Merged
jjerphan merged 4 commits into
mamba-org:mainfrom
jjerphan:maint/refactor-channel-loader
Feb 26, 2026
Merged

maint: Refactor Channel Loader#4169
jjerphan merged 4 commits into
mamba-org:mainfrom
jjerphan:maint/refactor-channel-loader

Conversation

@jjerphan
Copy link
Copy Markdown
Member

@jjerphan jjerphan commented Feb 20, 2026

Description

Mostly clarify the implementation and also add C++ tests.

Type of Change

  • Bugfix
  • Feature / enhancement
  • CI / Documentation
  • Maintenance

Checklist

  • My code follows the general style and conventions of the codebase, ensuring consistency
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have run pre-commit run --all locally in the source folder and confirmed that there are no linter errors.
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
@github-actions github-actions Bot added the release::maintenance For PRs related to maintenance label Feb 20, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 20, 2026

Codecov Report

❌ Patch coverage is 32.35294% with 46 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.43%. Comparing base (7603af9) to head (75872c7).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
libmamba/src/api/channel_loader.cpp 32.35% 46 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4169      +/-   ##
==========================================
+ Coverage   52.15%   52.43%   +0.28%     
==========================================
  Files         239      239              
  Lines       28803    28803              
  Branches     3029     3026       -3     
==========================================
+ Hits        15021    15102      +81     
+ Misses      13779    13698      -81     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread libmamba/src/api/channel_loader.cpp Outdated
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>

Co-authored-by: Johan Mabille <johan.mabille@gmail.com>
@jjerphan jjerphan marked this pull request as ready for review February 23, 2026 10:09
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
@jjerphan jjerphan force-pushed the maint/refactor-channel-loader branch from 65493d2 to 899ffbc Compare February 23, 2026 10:55
Comment thread libmamba/include/mamba/core/package_database_loader.hpp
Copy link
Copy Markdown
Member

@JohanMabille JohanMabille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when my last comment is adressed.

Comment thread libmamba/include/mamba/core/package_database_loader.hpp
Comment thread libmamba/src/api/channel_loader.cpp
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
@jjerphan jjerphan merged commit 3bb9f84 into mamba-org:main Feb 26, 2026
37 of 39 checks passed
@jjerphan jjerphan deleted the maint/refactor-channel-loader branch February 26, 2026 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release::maintenance For PRs related to maintenance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants