Skip to content

maint: Adapt Shards ownership model#4177

Merged
JohanMabille merged 4 commits into
mamba-org:mainfrom
jjerphan:maint/adapt-shards-ownership-model
Mar 9, 2026
Merged

maint: Adapt Shards ownership model#4177
JohanMabille merged 4 commits into
mamba-org:mainfrom
jjerphan:maint/adapt-shards-ownership-model

Conversation

@jjerphan
Copy link
Copy Markdown
Member

Description

Follow-up of #4162 (comment).

Type of Change

  • Bugfix
  • Feature / enhancement
  • CI / Documentation
  • Maintenance

Checklist

  • My code follows the general style and conventions of the codebase, ensuring consistency
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have run pre-commit run --all locally in the source folder and confirmed that there are no linter errors.
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
@github-actions github-actions Bot added the release::maintenance For PRs related to maintenance label Feb 27, 2026
@jjerphan jjerphan marked this pull request as ready for review February 27, 2026 15:31
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 27, 2026

Codecov Report

❌ Patch coverage is 66.00000% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.27%. Comparing base (3c948a4) to head (27d4c5a).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
libmamba/src/core/shard_traversal.cpp 76.74% 10 Missing ⚠️
libmamba/src/api/channel_loader.cpp 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4177      +/-   ##
==========================================
- Coverage   52.76%   52.27%   -0.50%     
==========================================
  Files         239      239              
  Lines       29065    29071       +6     
  Branches     3075     3076       +1     
==========================================
- Hits        15337    15197     -140     
- Misses      13725    13871     +146     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread libmamba/src/core/shard_traversal.cpp
jjerphan added 2 commits March 2, 2026 14:46
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
Comment thread libmamba/src/core/shard_traversal.cpp
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
@JohanMabille
Copy link
Copy Markdown
Member

JohanMabille commented Mar 9, 2026

The mamba-content-trust and windows tests failure are unrelated to this PR.

@JohanMabille JohanMabille merged commit 0804820 into mamba-org:main Mar 9, 2026
33 of 37 checks passed
@jjerphan jjerphan deleted the maint/adapt-shards-ownership-model branch March 9, 2026 19:12
@jjerphan jjerphan mentioned this pull request Mar 12, 2026
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release::maintenance For PRs related to maintenance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants