Skip to content

fix: Adapt Shards base URL to handle channel identifiers#4210

Merged
jjerphan merged 1 commit into
mamba-org:mainfrom
jjerphan:fix/adapt-shards-base-url
Mar 27, 2026
Merged

fix: Adapt Shards base URL to handle channel identifiers#4210
jjerphan merged 1 commit into
mamba-org:mainfrom
jjerphan:fix/adapt-shards-base-url

Conversation

@jjerphan
Copy link
Copy Markdown
Member

Description

This resolves some warnings when conda-forge's sharded repodata is used.

Type of Change

  • Bugfix
  • Feature / enhancement
  • CI / Documentation
  • Maintenance

Checklist

  • My code follows the general style and conventions of the codebase, ensuring consistency
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have run pre-commit run --all locally in the source folder and confirmed that there are no linter errors.
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

@github-actions github-actions Bot added the release::bug_fixes For PRs fixing bugs label Mar 24, 2026
@jjerphan jjerphan force-pushed the fix/adapt-shards-base-url branch from 007b910 to 5ab8a31 Compare March 24, 2026 16:11
@jjerphan jjerphan marked this pull request as ready for review March 24, 2026 16:11
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 24, 2026

Codecov Report

❌ Patch coverage is 70.00000% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.86%. Comparing base (6db7f56) to head (ae83f27).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
libmamba/src/core/shards.cpp 68.75% 10 Missing ⚠️
libmamba/src/core/channel_context.cpp 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4210      +/-   ##
==========================================
- Coverage   53.40%   52.86%   -0.55%     
==========================================
  Files         239      239              
  Lines       29301    29334      +33     
  Branches     3123     3127       +4     
==========================================
- Hits        15648    15506     -142     
- Misses      13650    13825     +175     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jjerphan jjerphan force-pushed the fix/adapt-shards-base-url branch 2 times, most recently from 0bdcef8 to 55fcdc7 Compare March 25, 2026 08:20
@jjerphan jjerphan changed the title fix: Adapt Shards base URL to handle relative URL fix: Adapt Shards base URL to handle channel identifiers Mar 25, 2026
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
@jjerphan jjerphan force-pushed the fix/adapt-shards-base-url branch from 55fcdc7 to ae83f27 Compare March 27, 2026 16:41
@jjerphan jjerphan merged commit 0d90b6a into mamba-org:main Mar 27, 2026
36 of 37 checks passed
@jjerphan jjerphan deleted the fix/adapt-shards-base-url branch March 27, 2026 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release::bug_fixes For PRs fixing bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants