Clarify that Node-specific files are replaced by Rollup in browser environments #7480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… by Rollup when bundling for browsers
ansis
approved these changes
Oct 25, 2018
Contributor
ansis
left a comment
ansis
left a comment
There was a problem hiding this comment.
This is great! I've been bitten by this before.
Contributor
|
Yeah me too, thanks @ryanhamley ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Launch Checklist
There was significant confusion when investigating Fix "localStorage is not available for opaque origins" error when using mapbox-gl-js-mock #7455 because it was not obvious how the JSDOM
windowinsrc/util/window.jswas being replaced by the browserwindow. These comments are intended to make the workflow clearer when reading the code.