Skip to content

Stub local and session storage in JSDOM #7516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryanhamley merged 4 commits into from
Oct 31, 2018
Merged

Stub local and session storage in JSDOM #7516

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ddfb2aa
Delete local and session storage from JSDOM
Oct 30, 2018
6f7e509
Add warning log in [local/session]Storage stub
Oct 31, 2018
5d4c018
Allow JSDOM to update in node modules
Oct 31, 2018
ac9df2d
Update warning message
Oct 31, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update warning message
  • Loading branch information
ryanhamley committed Oct 31, 2018
commit ac9df2d80b99e237f368495c140669ffee0461d7
2 changes: 1 addition & 1 deletion src/util/window.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ function restore(): Window {
// See https://github.com/mapbox/mapbox-gl-js/pull/7455 for discussion
delete window.localStorage;
delete window.sessionStorage;
window.localStorage = window.sessionStorage = () => console.log('local and session storage not available in Node');
window.localStorage = window.sessionStorage = () => console.log('Local and session storage not available in Node. Use a stub implementation if needed for testing.');

window.devicePixelRatio = 1;

Expand Down