Skip to content
This repository was archived by the owner on Aug 8, 2023. It is now read-only.

Fix within expression issue with geometry crossing the 180th Meridian#16330

Merged
zmiao merged 4 commits intomasterfrom
zmiao-fix-within-meridian
Mar 26, 2020
Merged

Fix within expression issue with geometry crossing the 180th Meridian#16330
zmiao merged 4 commits intomasterfrom
zmiao-fix-within-meridian

Conversation

@zmiao
Copy link
Copy Markdown
Contributor

@zmiao zmiao commented Mar 23, 2020

Fix: #16326

Parallel fix in gl-js: mapbox/mapbox-gl-js#9440

  • Add changelog

@zmiao zmiao self-assigned this Mar 23, 2020
@zmiao zmiao added the needs changelog Indicates PR needs a changelog entry prior to merging. label Mar 23, 2020
@zmiao zmiao force-pushed the zmiao-fix-within-meridian branch 2 times, most recently from 46fdac4 to a641aff Compare March 24, 2020 10:49
@zmiao zmiao marked this pull request as ready for review March 24, 2020 10:50
Copy link
Copy Markdown
Contributor

@pozdnyakov pozdnyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm % comment

Comment thread src/mbgl/style/expression/within.cpp Outdated
@zmiao zmiao force-pushed the zmiao-fix-within-meridian branch 5 times, most recently from 461ae78 to f764219 Compare March 25, 2020 09:30
@zmiao zmiao force-pushed the zmiao-fix-within-meridian branch from f764219 to 2d38d71 Compare March 25, 2020 16:29
@alexshalamov alexshalamov removed the needs changelog Indicates PR needs a changelog entry prior to merging. label Mar 26, 2020
@zmiao zmiao merged commit debf117 into master Mar 26, 2020
@zmiao zmiao deleted the zmiao-fix-within-meridian branch March 26, 2020 12:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

within expression behaves incorrectly when geometry crosses 180th Meridian

3 participants