This repository was archived by the owner on Aug 8, 2023. It is now read-only.
Hillshade bucket fix for mapbox-gl-native-ios #240#16362
Merged
Conversation
alexshalamov
changed the title
alexshalamov
approved these changes
Apr 1, 2020
Contributor
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: mapbox/mapbox-gl-native-ios#240
Approach copied from RasterBucket::upload - they both use SharedBucketTileRenderData.
I don't have render test for this: it is a bit tricky since neighboring DEM tiles should not be available in the same time (otherwise this cannot be reproduced).
When dem tiles are loaded, border in neighboring tiles is updated, too leading to bucket re-upload. if std::move moved indices / vertices previously, they are empty and we get crash.
Re-upload requires that only DEM texture is re-uploaded, not the quad vertices and indices.
Verified running macosapp.