#18 Cleanup, some comments

src/main/java/com/marklogic/appdeployer/command/modules/CommaDelimitedPermissionsParser.java

@@ -6,6 +6,11 @@
 import com.marklogic.xcc.ContentCapability;
 import com.marklogic.xcc.ContentPermission;
 
+/**
+ * Simple implementation that expects permissions to be comma-delimited in the format
+ * role1,capability1,role2,capability2,etc - just like when using mlcp.
+ *
+ */
 public class CommaDelimitedPermissionsParser implements PermissionsParser {
 
     @Override
@@ -15,21 +20,22 @@ public ContentPermission[] parsePermissions(String text) {
             String[] tokens = text.split(",");
             for (int i = 0; i < tokens.length; i += 2) {
                 String role = tokens[i];
-                String capability = tokens[i + 1];
-
-                ContentCapability cc = ContentCapability.READ;
-                if (capability.equals("execute")) {
-                    cc = ContentCapability.EXECUTE;
-                } else if (capability.equals("insert")) {
-                    cc = ContentCapability.INSERT;
-                } else if (capability.equals("update")) {
-                    cc = ContentCapability.UPDATE;
-                }
-
-                list.add(new ContentPermission(cc, role));
+                list.add(new ContentPermission(parseCapability(tokens[i + 1]), role));
             }
         }
         return list.toArray(new ContentPermission[] {});
     }
 
+    protected ContentCapability parseCapability(String capability) {
+        if (capability.equals("execute")) {
+            return ContentCapability.EXECUTE;
+        } else if (capability.equals("insert")) {
+            return ContentCapability.INSERT;
+        } else if (capability.equals("update")) {
+            return ContentCapability.UPDATE;
+        } else if (capability.equals("read")) {
+            return ContentCapability.READ;
+        }
+        throw new IllegalArgumentException("Unrecognized content capability: " + capability);
+    }
 }

src/main/java/com/marklogic/appdeployer/command/modules/DefaultDocumentFormatGetter.java

@@ -4,6 +4,10 @@
 
 import com.marklogic.xcc.DocumentFormat;
 
+/**
+ * Default impl that currently doesn't provide any support for binary. Feel free to enhance this, subclass it, or roll
+ * your own.
+ */
 public class DefaultDocumentFormatGetter implements DocumentFormatGetter {
 
     @Override

src/main/java/com/marklogic/appdeployer/command/modules/DocumentFormatGetter.java

@@ -4,6 +4,9 @@
 
 import com.marklogic.xcc.DocumentFormat;
 
+/**
+ * Encapsulates the logic for determining the document format of a given file.
+ */
 public interface DocumentFormatGetter {
 
     public DocumentFormat getDocumentFormat(File file);

src/main/java/com/marklogic/appdeployer/command/modules/PermissionsParser.java

@@ -2,6 +2,9 @@
 
 import com.marklogic.xcc.ContentPermission;
 
+/**
+ * Strategy interface for how XCC permissions are parsed from text.
+ */
 public interface PermissionsParser {
 
     public ContentPermission[] parsePermissions(String text);