Skip to content
This repository was archived by the owner on Sep 16, 2024. It is now read-only.

Getting ManageGroupsTest working #46

Merged
TammyHale merged 5 commits into from
Aug 6, 2015
Merged

Getting ManageGroupsTest working #46

TammyHale merged 5 commits into from
Aug 6, 2015

Conversation

@rjrudin
Copy link
Contributor

@rjrudin rjrudin commented Aug 3, 2015

Tammy - I made the following changes:

  • Combined the two ManageGroupsTest classes into one that's in the "appdeployer" root package
  • Created src/test/resources/sample-app/src/main/ml-config/groups/sample-app-group.json for ManageGroupsTest to use (I need to better document how this file is used by AbstractManageResourceTest)
  • I also bumped the sort order of CreateGroupsCommand from 1100 to 5, as I think we'd want groups to be deleted first.

Take a look, and if it looks good, merge it into issue-38. I'll then merge issue-38 into dev.

TammyHale added a commit that referenced this pull request Aug 6, 2015
@TammyHale
Merge pull request #46 from rjrudin/issue-38-rob
847f86a 
Getting ManageGroupsTest working
@TammyHale TammyHale merged commit 847f86a into issue-38 Aug 6, 2015
@TammyHale TammyHale deleted the issue-38-rob branch August 6, 2015 13:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rjrudin @TammyHale