Skip to content
This repository was archived by the owner on Sep 16, 2024. It is now read-only.

Conversation

@sastafford
Copy link
Contributor

Rob - I was using the ManageClient to get the configuration for the Rest APIs and came across this error. See the attached unit test.

@rjrudin
Copy link
Contributor

rjrudin commented Oct 2, 2015

If you add "?format=xml" to the path, you'll get back XML, and the test should work.

Now... should the getXml and getXmlAsAdmin methods automatically append that to the path that's passed in? They'd have to do some parsing work of the path to determine if a "?" exists or not and whether a format param exists or not - and what if someone mistakenly passes in format=json?

I think for now, it's fine to expect the user of ManageClient to construct the appropriate path, but I could be convinced otherwise.

@rjrudin
Copy link
Contributor

rjrudin commented Jan 18, 2016

Closing, I think it's reasonable to require the developer to add format=xml

@rjrudin rjrudin closed this Jan 18, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants