This repository was archived by the owner on Sep 16, 2024. It is now read-only.
Schemas db #84
Closed
Schemas db #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| private SchemasDataLoader schemasDataLoader; | ||
|
|
||
| public LoadSchemasDataCommand() { | ||
| setExecuteSortOrder(SortOrderConstants.DEPLOY_SQL_VIEWS); |
Contributor
There was a problem hiding this comment.
Should this use a different sort order? I'm wondering if its sort order should be right around when modules are loaded. I don't know enough about schemas to know if there are any dependencies on them that would govern when they should be loaded.
Contributor
Author
There was a problem hiding this comment.
You're right -- there could be modules that depend on shemas. I'll figure out where it goes, or make a new key for schemas
Created new sort order == 350 for this operation.
Contributor
Author
|
This PR has been updated. It will require some version munging to get the recent PR for ml-javaclient-util to support these additions. |
Contributor
|
I merged this into dev, which now depends on 2.8.0 of ml-javaclient-util. |
Contributor
Author
|
Thanks rob |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has changes to support loading data into the schemas database from data/schemas.
I can see that there are whitespace/formatting diffs that you might want purged -- look over this PR and let me know if you think it's OK otherwise.