Ignore fetch operands when assign initial nodes #2929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hekaisheng
force-pushed
the
enh/assign-fetch
branch
from
648762b to
f2407c4
Compare
hekaisheng
force-pushed
the
enh/assign-fetch
branch
from
9d608ca to
e319ab0
Compare
qinxuye
reviewed
Apr 18, 2022
mars/services/task/execution/api.py
Outdated
| """Get available band slots.""" | ||
|
|
||
| @abstractmethod | ||
| async def get_chunk_bands(self, chunk_keys: List[str]) -> Dict[str, BandType]: |
Collaborator
There was a problem hiding this comment.
About if it is reasonable to add this API to execution, what's your opinion? @fyrestone
Contributor
There was a problem hiding this comment.
The API is a bit wired for execution. From the title of the PR, I think may be the changes are related to graph construction not the execution?
Contributor
There was a problem hiding this comment.
Can you use the chunk to bands info for the graph assigner? https://github.com/mars-project/mars/blob/master/mars/services/task/supervisor/processor.py#L241
qinxuye
pushed a commit
to qinxuye/mars
that referenced
this pull request
Apr 21, 2022
(cherry picked from commit 1c4fbf7)
qinxuye
pushed a commit
to qinxuye/mars
that referenced
this pull request
Apr 22, 2022
(cherry picked from commit 1c4fbf7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
When trigger iterative tiling, subtask's graph may has fetch operand, and we treat them as initial nodes and assign them in
GraphAnalyzer, it will result in losing locality and bad performance. This PR try to solve this issue by ignoring fetch chunks when assign chunk graph.Related issue number
Fixes #xxxx
Check code requirements