Skip to content
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
nit cleanup
- Remove unused properties on *FormatterOptions
- ScopeProvider to be set outside of logger ctor
  • Loading branch information
maryamariyan committed May 14, 2020
commit 62aecebe8cdb2400e9a5b0265a8938fcfe27ef9e
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,6 @@ public void Dispose() { }
public partial class JsonLogFormatterOptions
{
public JsonLogFormatterOptions() { }
public bool DisableColors { get { throw null; } set { } }
public bool IncludeScopes { get { throw null; } set { } }
public System.Text.Json.JsonSerializerOptions JsonSerializerOptions { get { throw null; } set { } }
public System.Text.Json.JsonWriterOptions JsonWriterOptions { get { throw null; } set { } }
Expand Down Expand Up @@ -115,7 +114,6 @@ public void Dispose() { }
public partial class SystemdLogFormatterOptions
{
public SystemdLogFormatterOptions() { }
public bool DisableColors { get { throw null; } set { } }
public bool IncludeScopes { get { throw null; } set { } }
public Microsoft.Extensions.Logging.LogLevel LogToStandardErrorThreshold { get { throw null; } set { } }
public string TimestampFormat { get { throw null; } set { } }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,6 @@ internal ConsoleLogger(string name, ConsoleLoggerProcessor loggerProcessor)

_name = name;
_queueProcessor = loggerProcessor;
ScopeProvider = new LoggerExternalScopeProvider();

}

internal IExternalScopeProvider ScopeProvider { get; set; }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,6 @@ public JsonLogFormatterOptions() { }
/// </summary>
public bool IncludeScopes { get; set; }

/// <summary>
/// Disables colors when <see langword="true" />.
/// </summary>
public bool DisableColors { get; set; }

/// <summary>
/// Gets or sets value indicating the minimum level of messaged that would get written to <c>Console.Error</c>.
/// </summary>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,6 @@ public SystemdLogFormatterOptions() { }
/// </summary>
public bool IncludeScopes { get; set; }

/// <summary>
/// Disables colors when <see langword="true" />.
/// </summary>
public bool DisableColors { get; set; }

/// <summary>
/// Gets or sets value indicating the minimum level of messaged that would get written to <c>Console.Error</c>.
/// </summary>
Expand Down