Skip to content

Primitives #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
maryamariyan wants to merge 16 commits into from
Closed

Primitives #8

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
90ecb1f
Flat copy Primitives into runtime repo
maryamariyan Feb 10, 2020
f338827
Renames test folder to tests
maryamariyan Feb 18, 2020
be8c287
Header license update on cs files
maryamariyan Feb 18, 2020
d8c93a7
Fix compile ref project
maryamariyan Feb 18, 2020
ecbf709
Fix compile src project
maryamariyan Feb 18, 2020
573c43e
Fix compile test project
maryamariyan Feb 18, 2020
4adf23d
Add IsAspNetCoreApp to get separate packaging path
maryamariyan Feb 18, 2020
3d9a40d
Add solution file
maryamariyan Feb 18, 2020
4baac90
using target GenerateReferenceSource
maryamariyan Feb 20, 2020
ab78076
Fix api compat error
maryamariyan Feb 21, 2020
5ae9bb7
Reduce NoWarn errors (whitespace complaints)
maryamariyan Feb 21, 2020
d7b7d37
Remove HashCodeCombiner and use existing impl.
maryamariyan Feb 21, 2020
bcf37b8
Rename to ExcludeCurrentNetCoreAppFromPackage
maryamariyan Feb 21, 2020
b07bcd0
Fix StrongNameKeyId - get correct public key token
maryamariyan Feb 21, 2020
126b8eb
Use different PreReleaseVersionLabel for extensions projects
maryamariyan Feb 22, 2020
0d7f7dd
binplacing extensions libraries to a separate path
maryamariyan Feb 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
binplacing extensions libraries to a separate path
  • Loading branch information
@maryamariyan
maryamariyan committed Feb 22, 2020
commit 0d7f7dd85c47141629e65344f4f844b4560c0895
3 changes: 3 additions & 0 deletions src/libraries/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,6 +323,9 @@
<!-- Paths to binplace package content -->
<NETCoreAppPackageRefPath>$(ArtifactsBinDir)pkg\$(NetCoreAppCurrent)\ref</NETCoreAppPackageRefPath>
<NETCoreAppPackageRuntimePath>$(ArtifactsBinDir)pkg\$(NetCoreAppCurrent)\lib</NETCoreAppPackageRuntimePath>

<ASPNETCoreAppPackageRefPath>$(ArtifactsBinDir)pkg\aspnetcoreapp\ref</ASPNETCoreAppPackageRefPath>
<ASPNETCoreAppPackageRuntimePath>$(ArtifactsBinDir)pkg\aspnetcoreapp\lib</ASPNETCoreAppPackageRuntimePath>

<TestHostRootPath>$([MSBuild]::NormalizeDirectory('$(ArtifactsBinDir)', 'testhost', '$(BuildConfiguration)'))</TestHostRootPath>

Expand Down
4 changes: 2 additions & 2 deletions src/libraries/Directory.Build.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,8 @@
<SetProperties Condition="'$(BinPlaceRuntime)' == 'true' and '$(ILLinkTrimAssembly)' == ''">ILLinkTrimAssembly=true</SetProperties>
</BinPlaceTargetFrameworks>
<BinPlaceTargetFrameworks Condition="'$(IsAspNetCoreApp)' == 'true'" Include="$(NetCoreAppCurrent)">
<RuntimePath Condition="'$(AspNetCoreRuntimePath)' == 'true'">C:\CodeHub\runtime\artifacts\bin\pkg\aspnetcore\runtime</RuntimePath>
<RefPath Condition="'$(AspNetCoreRuntimePath)' == 'true'">C:\CodeHub\runtime\artifacts\bin\pkg\aspnetcore\ref</RefPath>
<RuntimePath>$(ASPNETCoreAppPackageRuntimePath)</RuntimePath>
<RefPath>$(ASPNETCoreAppPackageRefPath)</RefPath>
</BinPlaceTargetFrameworks>

<!-- Setup the shared framework directory for testing -->
Expand Down