This repository was archived by the owner on Nov 21, 2024. It is now read-only.
Move Material Theme Builder from MDC library repo to material-components-android-examples. #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change color.xml to hold palette for light and dark themes (non-semantically named colors) - Update color.xml comments - Update README color section - Update to use MDC's emphasized "on" ColorStateLists - Update TypeAttributeView to accept a CSL for its text color - Remove unnecessary platform theme attrs Issue: material-components/material-components-android#715"
hunterstich
requested review from
dsn5ft,
nickbutcher,
ricknout and
yasmineevjen
Contributor
|
How about |
Contributor
|
This looks good 👍 Agree with @dsn5ft about the change of directory name. |
Contributor
Author
|
Renamed! Thanks Dan and Nick. |
ricknout
approved these changes
Jan 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.