-
Notifications
You must be signed in to change notification settings - Fork 230
chore: catalog example #966
Conversation
Oh example directory is also test target! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix lint. Good idea adding a new example.
Codecov Report
@@ Coverage Diff @@
## rc0.15.0 #966 +/- ##
============================================
+ Coverage 94.12% 94.13% +<.01%
============================================
Files 86 86
Lines 3645 3647 +2
Branches 576 578 +2
============================================
+ Hits 3431 3433 +2
Misses 90 90
Partials 124 124
Continue to review full report at Codecov.
|
@TroyTae |
Getting an error when i run:
|
@moog16 |
This reverts commit 0bb2281.
<MenuContext.Consumer> | ||
{({selectedIndex}) => ( | ||
<TopAppBarFixedAdjust> | ||
{React.createElement(Menus[selectedIndex].component)} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like an antipattern. Sorry I didn't pick this up before. What is going on here. Is this the recommended usage?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot sure that this pattern is a recommendation.
But I know that JSX is compiled like this:
<MyComponent></MyComponent> => React.createElement(MyComponent, someProps)
And I see this doc. (https://reactjs.org/docs/react-without-jsx.html)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok fair enough! :)
@moog16 |
Looks good! |
MDC react example that looks like catalog!