Skip to content
This repository was archived by the owner on Jul 29, 2025. It is now read-only.

Conversation

ghost
Copy link

@ghost ghost commented Jul 7, 2019

MDC react example that looks like catalog!

@ghost
Copy link
Author

ghost commented Jul 8, 2019

Oh example directory is also test target!
Is there something that I need to do additionally?

Copy link

@moog16 moog16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix lint. Good idea adding a new example.

@codecov-io
Copy link

codecov-io commented Jul 9, 2019

Codecov Report

Merging #966 into rc0.15.0 will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           rc0.15.0     #966      +/-   ##
============================================
+ Coverage     94.12%   94.13%   +<.01%     
============================================
  Files            86       86              
  Lines          3645     3647       +2     
  Branches        576      578       +2     
============================================
+ Hits           3431     3433       +2     
  Misses           90       90              
  Partials        124      124
Impacted Files Coverage Δ
packages/list/index.tsx 94.88% <0%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aabe0c1...5dba48c. Read the comment docs.

@ghost
Copy link
Author

ghost commented Jul 9, 2019

@TroyTae
It looks might better to exclude examples directory in tsconfig 😅

@moog16
Copy link

moog16 commented Jul 11, 2019

Getting an error when i run:

rm -rf node_modules
npm i
npm start
[tsl] ERROR
      TS18003: No inputs were found in config file 'tsconfig.json'. Specified 'include' paths were '["**/*"]' and 'exclude' paths were '["../../node_modules","../../examples","../../build"]'.

ERROR in ./src/App.tsx
Module build failed (from ./node_modules/ts-loader/index.js):
Error: error while parsing tsconfig.json

@ghost
Copy link
Author

ghost commented Jul 12, 2019

@moog16
I fixed it!

This reverts commit 0bb2281.
<MenuContext.Consumer>
{({selectedIndex}) => (
<TopAppBarFixedAdjust>
{React.createElement(Menus[selectedIndex].component)}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like an antipattern. Sorry I didn't pick this up before. What is going on here. Is this the recommended usage?

Copy link
Author

@ghost ghost Jul 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot sure that this pattern is a recommendation.
But I know that JSX is compiled like this:

<MyComponent></MyComponent> => React.createElement(MyComponent, someProps)

And I see this doc. (https://reactjs.org/docs/react-without-jsx.html)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok fair enough! :)

@ghost
Copy link
Author

ghost commented Jul 16, 2019

@moog16
I checked all of files.
And it looks inline function is only in ChipsExample.
Thank you!

@moog16
Copy link

moog16 commented Jul 16, 2019

Looks good!

@moog16 moog16 merged commit 15f64c2 into material-components:rc0.15.0 Jul 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants