Skip to content

Revert "WSL support" - #17

Merged
Claudiohbsantos merged 1 commit intomasterfrom
revert-16-refactor-wsl
Jul 16, 2021
Merged

Revert "WSL support" - #17
Claudiohbsantos merged 1 commit intomasterfrom
revert-16-refactor-wsl

Conversation

@Claudiohbsantos
Copy link
Member

Reverts #16

@shivapoudel

Unfortunately I jumped the gun merging the PR. The new version of parcel doesn't seem to work on Windows (testing with node 14.16.1) .

Since the changes are non-critical to a release I am reverting the merge in order to cut a manual release and then we can address these later

Errors:

to log errors, add .catch(console.error) to the end of line 11 in build-src.js (I'll add this to the codebase, it's just easier to manually add here than mucking with branches)

with with versions in PR:

[2/2] Bundle extension manifest, images and main script.
[ThrowableDiagnostic [Error]: Invalid Parcel Config] {
  diagnostics: [
    {
      message: 'Invalid Parcel Config',
      origin: '@parcel/core',
      filePath: 'node_modules\\@parcel\\config-default\\index.json',
      language: 'json',
      codeFrame: [Object]
    }
  ]
}

with latest versions: parcel 2.0.0-beta.3.1 & @parcel/config-default 2.0.0-beta.3.1:

[2/2] Bundle extension manifest, images and main script.
AssertionError [ERR_ASSERTION]: Bundles must have unique names
    at BundlerRunner.nameBundles (U:\Dev\github-material-icons-extension\node_modules\@parcel\core\lib\requests\BundleGraphRequest.js:482:23)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
    at async BundlerRunner.bundle (U:\Dev\github-material-icons-extension\node_modules\@parcel\core\lib\requests\BundleGraphRequest.js:434:5)
    at async RequestTracker.runRequest (U:\Dev\github-material-icons-extension\node_modules\@parcel\core\lib\RequestTracker.js:694:20)
    at async Parcel._build (U:\Dev\github-material-icons-extension\node_modules\@parcel\core\lib\Parcel.js:661:25)
    at async Parcel.run (U:\Dev\github-material-icons-extension\node_modules\@parcel\core\lib\Parcel.js:510:18)
    at async Promise.all (index 2) {
  diagnostics: [
    {
      origin: 'Error',
      message: 'Bundles must have unique names',
      name: 'AssertionError',
      filePath: undefined,
      stack: 'AssertionError [ERR_ASSERTION]: Bundles must have unique names\n' +
        '    at BundlerRunner.nameBundles (U:\\Dev\\github-material-icons-extension\\node_modules\\@parcel\\core\\lib\\requests\\BundleGraphRequest.js:482:23)\n' +
        '    at processTicksAndRejections (internal/process/task_queues.js:93:5)\n' +
        '    at async BundlerRunner.bundle (U:\\Dev\\github-material-icons-extension\\node_modules\\@parcel\\core\\lib\\requests\\BundleGraphRequest.js:434:5)\n' +
        '    at async RequestTracker.runRequest (U:\\Dev\\github-material-icons-extension\\node_modules\\@parcel\\core\\lib\\RequestTracker.js:694:20)\n' +
        '    at async Parcel._build (U:\\Dev\\github-material-icons-extension\\node_modules\\@parcel\\core\\lib\\Parcel.js:661:25)\n' +
        '    at async Parcel.run (U:\\Dev\\github-material-icons-extension\\node_modules\\@parcel\\core\\lib\\Parcel.js:510:18)\n' +
        '    at async Promise.all (index 2)',
      codeFrame: undefined
    }
  ],
  name: 'BuildError'
}

@Claudiohbsantos Claudiohbsantos merged commit 0ec38cb into master Jul 16, 2021
@Claudiohbsantos Claudiohbsantos deleted the revert-16-refactor-wsl branch July 16, 2021 03:52
@shivapoudel
Copy link
Contributor

CC @4086606

@ghost
Copy link

ghost commented Dec 20, 2021

I did read this previously but didn't know Parcel 2 was broken for the config change in Windows. Good call though. Maybe it's stabler now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants