Merged
Conversation
Contributor
|
CC @4086606 |
|
I did read this previously but didn't know Parcel 2 was broken for the config change in Windows. Good call though. Maybe it's stabler now? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #16
@shivapoudel
Unfortunately I jumped the gun merging the PR. The new version of parcel doesn't seem to work on Windows (testing with node 14.16.1) .
Since the changes are non-critical to a release I am reverting the merge in order to cut a manual release and then we can address these later
Errors:
to log errors, add
.catch(console.error)to the end of line 11 in build-src.js (I'll add this to the codebase, it's just easier to manually add here than mucking with branches)with with versions in PR:
with latest versions: parcel
2.0.0-beta.3.1& @parcel/config-default2.0.0-beta.3.1: