Fix ESLint config#38
Fix ESLint config#38Claudiohbsantos merged 18 commits intomaterial-extensions:masterfrom csandman:eslint-fix
Conversation
- Fix the ESLint config - Fix all lint errors that cropped up as a result - Add scripts to lint - Add prettier format script - Add `husky` / `lint-staged` to lint/format files when they're pushed
Update Branch
|
Ops, I didn't realize you had this marked as Draft. This all looks good to me, thanks! I fixed the conflicts and added a commit with 2 eslint warning fixes + some non-eslint things I found on the way. Were you planning to add anything to this PR? I'm happy to merge it whenever you mark it ready for review |
Remove unused `@types/node-fetch` package
…eplaceIcon` functions
|
@Claudiohbsantos I had actually only drafted this PR to try and resolve the merge conflicts on GitHub (which I failed to do). I ended up making a new branch with all the final changes from a clean branch of the current master, but I also just pushed them here. So yeah, if you want to help me resolve the remaining conflicts then this branch is ready to go! |
|
@csandman This looks great, thanks for taking care of all of the chores here! Yeah, I've been making a couple of changes to master so it was pretty easy to solve the conflicts since I remembered what I changed yesterday. I'm going to go ahead and merge this one in! |
eslint-plugin-jsdocpackage, as this project uses JSDoc in multiple places with some invalid types.eslint-plugin-prettierpackage in favor ofeslint-config-prettierbecause they don't recommend using it.json-stable-stringifypackagehuskyandlint-stagedto format with prettier and lint the code in a pre-commit hook.@types/node-fetchpackage as this is not a TS project and it serves no purpose(?)enginesfields in thepackage.jsonto allow anything onnode@16andnpm@8because installing the dependencies is a pain otherwise. You can revert this if there is a specific reason for restricting them to these versions.