Skip to content

Fix ESLint config#38

Merged
Claudiohbsantos merged 18 commits intomaterial-extensions:masterfrom
csandman:eslint-fix
Jul 1, 2022
Merged

Fix ESLint config#38
Claudiohbsantos merged 18 commits intomaterial-extensions:masterfrom
csandman:eslint-fix

Conversation

@csandman
Copy link
Contributor

@csandman csandman commented Jun 29, 2022

  • Update all ESLint packages, install the proper ones for this project, and update the config so it is no longer broken.
    • Add the eslint-plugin-jsdoc package, as this project uses JSDoc in multiple places with some invalid types.
    • Remove the eslint-plugin-prettier package in favor of eslint-config-prettier because they don't recommend using it.
    • Fix all of the ESLint warnings and errors that popped up as a result of fixing the config.
    • Add the missing json-stable-stringify package
  • Add husky and lint-staged to format with prettier and lint the code in a pre-commit hook.
    • Run a prettier format on all files so that the hooks can do their job in the future
  • Remove the @types/node-fetch package as this is not a TS project and it serves no purpose(?)
  • Change the engines fields in the package.json to allow anything on node@16 and npm@8 because installing the dependencies is a pain otherwise. You can revert this if there is a specific reason for restricting them to these versions.

@Claudiohbsantos
Copy link
Member

Claudiohbsantos commented Jun 30, 2022

Ops, I didn't realize you had this marked as Draft. This all looks good to me, thanks!

I fixed the conflicts and added a commit with 2 eslint warning fixes + some non-eslint things I found on the way.

Were you planning to add anything to this PR? I'm happy to merge it whenever you mark it ready for review

@csandman csandman marked this pull request as ready for review June 30, 2022 18:11
@csandman
Copy link
Contributor Author

@Claudiohbsantos I had actually only drafted this PR to try and resolve the merge conflicts on GitHub (which I failed to do). I ended up making a new branch with all the final changes from a clean branch of the current master, but I also just pushed them here. So yeah, if you want to help me resolve the remaining conflicts then this branch is ready to go!

@Claudiohbsantos
Copy link
Member

@csandman This looks great, thanks for taking care of all of the chores here! Yeah, I've been making a couple of changes to master so it was pretty easy to solve the conflicts since I remembered what I changed yesterday. I'm going to go ahead and merge this one in!

@Claudiohbsantos Claudiohbsantos merged commit 05f9f8c into material-extensions:master Jul 1, 2022
@csandman csandman deleted the eslint-fix branch July 1, 2022 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants