Skip to content

visualstudio.com support#42

Merged
Claudiohbsantos merged 5 commits intomaterial-extensions:masterfrom
csandman:visualstudio-support
Jul 17, 2022
Merged

visualstudio.com support#42
Claudiohbsantos merged 5 commits intomaterial-extensions:masterfrom
csandman:visualstudio-support

Conversation

@csandman
Copy link
Contributor

@csandman csandman commented Jul 5, 2022

I figured I might as well make a PR for this as I made the original provider haha. I can't really test it as I don't have access to a visualstudio.com azure devops repo, but I can't see why this wouldn't work

@jamiehaywood
Copy link

jamiehaywood commented Jul 6, 2022

will test locally and post a screenshot

@jamiehaywood
Copy link

I've tried testing & it doesn't seem to be working. It must be a selector that's slightly different. I've got a visualstudio repo for you to test on: https://jamieadhaywood.visualstudio.com/Test/_git/Test

@jamiehaywood
Copy link

I will try and have a look into it this weekend, given I was the feature requester :D

@csandman
Copy link
Contributor Author

csandman commented Jul 7, 2022

It looks like I missed the *. at the beginning of the URL matches in the manifest, can you give my most recent push a try? The URL you provided seems to be working for me!

@jamiehaywood
Copy link

image

can confirm this is working. ready to merge I think 😄 what do you think @Claudiohbsantos ?

Copy link
Member

@Claudiohbsantos Claudiohbsantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is perfect, short and simple:) Thanks for jumping on this @csandman and @jamiehaywood

Looks good to me. I'm going to approve already and hold the merge for a sec until I figure out the best way to avoid spamming users with permission change notifications. I'll aim to merge this week along with the other approved PR.

@Claudiohbsantos Claudiohbsantos merged commit cf78a0c into material-extensions:master Jul 17, 2022
@csandman csandman deleted the visualstudio-support branch July 18, 2022 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support visualstudio.com url for Azure Repos

3 participants