Skip to content

Github action to publish to edge store#45

Merged
Claudiohbsantos merged 2 commits intomaterial-extensions:masterfrom
shivapoudel:action/edge
Oct 24, 2022
Merged

Github action to publish to edge store#45
Claudiohbsantos merged 2 commits intomaterial-extensions:masterfrom
shivapoudel:action/edge

Conversation

@shivapoudel
Copy link
Contributor

@shivapoudel shivapoudel commented Oct 13, 2022

Please check your Instagram where I have sent you the GitHub secret used in this PR.

@shivapoudel shivapoudel marked this pull request as ready for review October 13, 2022 19:47
Copy link
Member

@Claudiohbsantos Claudiohbsantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this. I already added the secrets to the repo. I left 2 comment but the only one I'm considering blocking for the merge is the addition to update-from-upstream.yml since that's the workflow that is most often responsible for version bumps. Since it's essentially a copy/paste job I don't mind doing that later if I get to if before you.

@Claudiohbsantos Claudiohbsantos dismissed their stale review October 17, 2022 20:20

Accidental approval. Removing approval so I don't forget to check for the changes in comments before merging

@shivapoudel
Copy link
Contributor Author

@Claudiohbsantos please review the copy/paste job buddy :)

Copy link
Member

@Claudiohbsantos Claudiohbsantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

I'll merge this already and tackle the manual trigger inputs separately. This way we can observe how well this works with automated updates already.

@Claudiohbsantos Claudiohbsantos merged commit 0a0beb1 into material-extensions:master Oct 24, 2022
@shivapoudel shivapoudel deleted the action/edge branch October 25, 2022 03:29
@Claudiohbsantos
Copy link
Member

@shivapoudel It looks like the Edge submission is stuck on the store? Not sure if it's just still going through review. I just checked the action logs here and don't see any issues. No rush to look into this, just giving you a heads up since the next step is probably to check the submission status in the Edge store

@shivapoudel
Copy link
Contributor Author

@Claudiohbsantos It is in the review process, my friend :)
image

@shivapoudel
Copy link
Contributor Author

@Claudiohbsantos Extension is now published in the edge store ❤️

@Claudiohbsantos
Copy link
Member

Awesome! Thanks for checking, just wanted to have a baseline for how quickly it moves through the pipes to know when to start looking into failures in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants