Fix the extra icons added when changing icon packs#64
Merged
Claudiohbsantos merged 1 commit intomaterial-extensions:masterfrom Apr 28, 2023
Merged
Fix the extra icons added when changing icon packs#64Claudiohbsantos merged 1 commit intomaterial-extensions:masterfrom
Claudiohbsantos merged 1 commit intomaterial-extensions:masterfrom
Conversation
Claudiohbsantos
approved these changes
Apr 28, 2023
Member
Claudiohbsantos
left a comment
Claudiohbsantos
left a comment
There was a problem hiding this comment.
Yeah, this looks great to me. That was some quick work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #63
This PR fixes the issue of the extra icons being added when the icon packs are switched. It appears the issue is being caused by the prepend behavior I used for the new icons. In the case where you attempt to replace the icon from this pack, it doesn't see a previous sibling with the icon pack, so it just prepends it.
The fix was checking to see if the
svgElthe extension is looking at actually comes from this pack, and in the case where it does, actually do a replace instead of prepending it.