Skip to content

WIP: add type hints #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

WIP: add type hints #1

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7c7f840
WIP: add type hints
ZetaTwo May 23, 2022
36b4577
WIP: more type hints
ZetaTwo May 23, 2022
19d7fbb
WIP: more type hints
ZetaTwo May 23, 2022
3f361db
WIP: more type hints
ZetaTwo May 23, 2022
41d07ef
Add requirements and remove duplicate imports
ZetaTwo Jan 11, 2024
7bd470a
Fix tests. Add makefile. Re-organise dependencies
ZetaTwo Jan 11, 2024
c2349d0
fix file permissions
ZetaTwo Jan 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
WIP: more type hints
  • Loading branch information
@ZetaTwo
ZetaTwo committed Jan 11, 2024
commit 3f361dbf32bc52e6b155f76b4682818e7d9fcfaa
9 changes: 5 additions & 4 deletions challtools/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,9 +188,10 @@ def get_valid_config(workdir: Optional[Union[str, Path]] = None, search: bool =
Raises:
CriticalException: If there are critical validation errors
"""
config = load_config(
search=search, cd=cd, **{"workdir": workdir} if workdir else {}
)
if workdir:
config = load_config(search=search, cd=cd, workdir=workdir)
else:
config = load_config(search=search, cd=cd)

validator = ConfigValidator(config)
messages = validator.validate()[1]
Expand Down Expand Up @@ -223,7 +224,7 @@ def get_valid_config(workdir: Optional[Union[str, Path]] = None, search: bool =
return validator.normalized_config


def discover_challenges(search_start: Optional[bool] = None) -> List[Path]:
def discover_challenges(search_start: Optional[str] = None) -> Optional[List[Path]]:
"""Discovers all challenges at the same level as or in a subdirectory below the CTF configuration file.

Returns:
Expand Down