Fix some copying issues. #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cycler.py
Outdated
There was a problem hiding this comment.
This isn't deep enough to protect against changing the key, but this depends on how #13 ends up being implemented
In [80]: dd = [{a: a} for a in range(3)]
In [81]: import copy
In [82]: dd2 = copy.copy(dd)
In [83]: dd[0][0] = 'foobare'
In [84]: dd2
Out[84]: [{0: 'foobare'}, {1: 1}, {2: 2}]
I think this needs to be
self._left = [dict(v) for v in left]
|
ok, I reworked it a bit, and even managed to get rid of the ugly |
|
Oh, that is nice. If I had thought of that originally the function |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues discovered while working on the key rename PR.