-
Notifications
You must be signed in to change notification settings - Fork 434
MSC4108: Mechanism to allow OAuth 2.0 API sign in and E2EE set up via QR code #4108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hughns
wants to merge
71
commits into
main
Choose a base branch
from
element-hq/oidc-qr-login
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+904
−0
Open
Changes from 1 commit
Commits
Show all changes
71 commits
Select commit
Hold shift + click to select a range
6e42f10
Placeholder
hughns d90eda1
MSC4108
hughns f7bbba3
WIP of MSC4108
hughns 177a2db
Auto numbers don't work on non-sequential items
hughns f54e194
High level description of rendezvous protocol and consistency in payl…
hughns f34bec3
Cheat spell checker
hughns 2830e88
Description of rendezvous session API
hughns 24e2242
Add description of QR format
hughns 21ae2ca
Lint
hughns 38eb661
Notes on threat model
hughns 9cd724f
Fix broken link
hughns db759ea
Resolve some more TODOs
hughns 5d6fb4a
Merge branch 'element-hq/oidc-qr-login' of https://github.com/matrix-…
hughns 4e425af
Define POST response body explicitly
hughns a302c39
Add Cache-Control and Pragma HTTP response headers
hughns a81491c
Add error codes
hughns e1f7367
Formatting
hughns d8c62ed
Whitespace
hughns ad31acf
More formatting
hughns aa37af9
Tweaks to the QR code login crypto (#4129)
dkasak 289a810
Add missing device id check step to sequence diagram
hughns 25e8fcb
Remove references to rendezvous session ID
hughns e12945c
Fix POST endpoint and Location references
hughns 4f9a4a4
Rendezvous sessions should have a fixed lifetime and allow enough tim…
hughns fbb30ec
Set max payload size to 4KB and fix content-type as text/plain (#4134)
hughns fe939be
Cross signing is mandatory
hughns 76f175b
Use unstable prefix for errcode
hughns 0ca3dea
The If-Match header on PUT requests contains the ETag
hughns 02f18e1
Fix description of 304 GET response
hughns f49fd7f
Fix m.login.failure reason typo
hughns 73da95a
Fix originator of m.login.declined
hughns 87f8317
Use server name rather than base URL and clarify well-known discovery
hughns 0b315f5
Update 4108-oidc-qr-login.md
hughns 3545ca0
Update to match spec 1.15 and MSC4341
hughns bb5f080
Update links from spec 1.10 to 1.15
hughns 2dc580e
Feedback from review
hughns 34ade3c
Min and mix rendezvous timeouts
hughns 0e1dd7c
Add table of contents
hughns 98aedb5
Suggestions from @uhoreg
hughns 3bbba40
Fix incorrect string
hughns d6a491b
All nonces start at 0
hughns 6f05cf2
Make rendezvous API more like rests of Client-Server API
hughns 2eba218
Make 429 errcode be M_LIMIT_EXCEEDED
hughns ad71936
Add note bout message prefix
hughns 1ec7d9c
Remove further references to rendezvous server
hughns a92f128
Fix more references to OAuth and MSC4341
hughns ced4466
More consistency on SecureSend/SecureReceive
hughns 4416161
Split out steps and reorder for clarity
hughns e032ea7
And example for `device_already_exists` outcome
hughns 9dab408
Rendezvous authentication and optionality
hughns da56332
Add alternative about unauthenticated device creating "redirect channel"
hughns 6612944
Fix description of discovery steps
hughns 9ea6d7d
Move QR format part of proposal to where it sits in the flow
hughns 66a9124
QR code clarifications
hughns fce6f15
Wording on new/existing device
hughns 95be8fd
Remove another reference to reciprocate
hughns 740da4b
Reinstate note about long poll for future
hughns 7d768f7
Revert removal of public key from example QRs
hughns 82e775f
Clarify 4KB
hughns 3f1321b
Clarifications around public key in QR
hughns 1d45957
GitHub doesn't like the link syntax I used
hughns af0a6bf
Update unstable prefixes including on QR code
hughns a4af2d6
Update QR code format under "type" 0x03
hughns 83071d9
Use base URL in QR code and m.login.protocols message
hughns c5a9dc7
Update QR examples to match description
hughns 41eaa2a
Split secure channel into MSC4388 + add intro diagram
hughns c0431eb
Update proposals/4108-oidc-qr-login.md
hughns 5f6828d
Remove old QR codes as now part of MSC4388
hughns 042e5ab
Add unable_to_open_verification_uri failure reason
hughns 59cb21c
Add an example of where user_cancelled can be used
hughns ec24672
Complete the "potential issues" section
hughns File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Notes on threat model
- Loading branch information
commit 38eb66151ee558d2615fbda429954455b80e5eee
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.