Skip to content

Conversation

@DMRobertson
Copy link
Contributor

@DMRobertson DMRobertson commented Nov 22, 2021

I wrote out an action only to realise that it basically already existed here. Two key differences:

It's triggered when we make a release on github.

I tried to test this on pull_request, but I don't think it's possible to test a new workflow until it's been merged into main? Given that it's against the test instance, I suggest we screw it and commit it anyway.

@DMRobertson DMRobertson requested a review from a team as a code owner November 22, 2021 15:36
@DMRobertson DMRobertson marked this pull request as draft November 22, 2021 15:40
@DMRobertson DMRobertson marked this pull request as ready for review November 22, 2021 15:56
@DMRobertson DMRobertson changed the title Test uploading to PyPI on tag creation Test uploading to PyPI on release Nov 22, 2021
Copy link
Member

@erikjohnston erikjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, why not

@DMRobertson DMRobertson merged commit af3d6c8 into main Nov 23, 2021
@DMRobertson DMRobertson deleted the dmr/test-pypi-ci branch November 23, 2021 15:13
@DMRobertson
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants