Add Mastodon bridge#16
Merged
Merged
Conversation
Collaborator
Author
|
Still a few errors silently discarded that should be logged. Don't merge yet |
|
https://hemaks.org/posts/why-your-obsession-with-code-linting-is-excessive/ Consider these questions when evaluating your linting setup:
|
5877d1c to
472f441
Compare
Collaborator
Author
|
Added some helper tweaks in #20. Once it is merged this PR can be rebased and reviewed properly. |
Collaborator
|
@lil5 could you please test if this is still working as expected? Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New attempt at fixing linter errors
The context is passed by function argument as recommended by golang.
Deferred error checking is applied, simply printing a warning in case of error.
And errors are typed.