Skip to content

Matrix attachment improvements #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
selfhoster1312 merged 3 commits into from
Mar 2, 2026
Merged

Matrix attachment improvements #169

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0395d8e
matrix: Don't check announced file size, HTTP client will do it
selfhoster1312 Mar 2, 2026
18aed01
matrix: Attachment message body is actually caption
selfhoster1312 Mar 2, 2026
0d64260
matrix: file extension is added even for non-image attachments
selfhoster1312 Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
matrix: Don't check announced file size, HTTP client will do it
  • Loading branch information
@selfhoster1312
selfhoster1312 committed Mar 2, 2026
commit 0395d8eefbe8fe8ae30b6c9079e3ca642598ddc3
5 changes: 0 additions & 5 deletions bridge/matrix/matrix.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -757,7 +757,6 @@ func (b *Bmatrix) handleDownloadFile(rmsg *config.Message, content event.Content
ok bool
url, name, msgtype, mtype string
info map[string]interface{}
size float64
)

rmsg.Extra = make(map[string][]interface{})
Expand All @@ -774,10 +773,6 @@ func (b *Bmatrix) handleDownloadFile(rmsg *config.Message, content event.Content
return fmt.Errorf("info isn't a %T", info)
}

if size, ok = info["size"].(float64); !ok {
return fmt.Errorf("size isn't a %T", size)
}

if name, ok = content.Raw["body"].(string); !ok {
return fmt.Errorf("name isn't a %T", name)
}
Expand Down
2 changes: 1 addition & 1 deletion changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
the return code is not 200 to avoid saving trash data ([#20](https://github.com/matterbridge-org/matterbridge/pull/20))
- matrix
- attachments received from matrix are working again, with authenticated media (MSC3916) implemented ([#61](https://github.com/matterbridge-org/matterbridge/pull/61))
- image attachments are now send as images with more metadata ([#61](https://github.com/matterbridge-org/matterbridge/pull/61))
- image attachments are now sent as images with more metadata ([#61](https://github.com/matterbridge-org/matterbridge/pull/61))
- xmpp
- various upstream go-xmpp changes fix connection on SASL2 with PLAIN auth
- telegram
Expand Down