discord: Ignore old message edits#199
Conversation
9a4ffca to
92e1510
Compare
|
Great. Do you think it would be hard to make the max edit duration configurable? Also, we need a changelog entry and documentation in the Discord bridge docs for it. Thanks. |
Based on #132 (comment) I believe that is already in. Still needs a default and probably a special value like -1 to disable.
I'll figure out what that means. Ideally I'd like to know how to handle the lint issue and have confirmation on the config setting before documenting it. Well, actually I just asked on IRC about the lint issue. The same code the linter mentions already exists in the pre-existing line above and there are more cases in the file as far as I can tell so it might be weird to just change one instance? How is that normally handled? |
|
We decided to fix lint issues only as they come up. Fixing the entire codebase would be a lot of work and just ignoring them entirely seems like a bad idea. So hopefully over time they get fixed as people touch parts of the codebase. |
92e1510 to
6a94029
Compare
|
Changed the setting to Documentation should be all there now? (Fixed indentation of the whatsapp entry in the changelog) |
|
Btw, even better would be to ignore edits that don't actually change anything since those also happen earlier and are not useful to show either. No idea how to do that though... |
|
Might be too complicated to add that. Overall the PR looks good now, but maybe you could still add a note to the documentation that this global config variable is currently only supported by the Discord bridge? Thanks! |
Since discord occasionally sends spurious message edits for old messages make it possible to ignore those older than EditMaxDays.
6a94029 to
6c5531b
Compare
Since discord occasionally sends spurious message edits for old messages make it possible to ignore those older than MaxEditDays.
Based on https://github.com/42wim/matterbridge/pull/2239/changes and discussion in #132.