Skip to content

Matt Wright - Sprint-Data-Structures #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Matt Wright - Sprint-Data-Structures #1

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
547c4cf
initial commit
mattwright42 Mar 1, 2019
a8f76e9
completes binary_search_tree with breadth_first_for_each
mattwright42 Mar 1, 2019
ae2f480
adds optimization down to 2 seconds (from 11 seconds)
mattwright42 Mar 1, 2019
3af5de5
completes names with some optimized runtimes
mattwright42 Mar 1, 2019
d7ac76b
Completes Data_Structures_Answers
mattwright42 Mar 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
completes names with some optimized runtimes
  • Loading branch information
@mattwright42
mattwright42 committed Mar 1, 2019
commit 3af5de572262b1abcf7e0cb2211dd026d74db9cf
13 changes: 10 additions & 3 deletions names/names.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,16 @@
# if name_1 == name_2:
# duplicates.append(name_1)

for name_1 in names_1:
if name_1 in names_2:
duplicates.append(name_1)
# This one takes about 2 seconds to run
# for name_1 in names_1:
# if name_1 in names_2:
# duplicates.append(name_1)

# Trying an attempt using sets - runtime = 0.005786895751953125 seconds
set_1 = set(names_1)
set_2 = set(names_2)

duplicates.append(str(set_1 & set_2))

end_time = time.time()
print(f"{len(duplicates)} duplicates:\n\n{', '.join(duplicates)}\n\n")
Expand Down