Skip to content

Conversation

@ai
Copy link
Contributor

@ai ai commented Jun 3, 2022

Summary

I added oklch() and oklab() from CSS Colors 4 to color types.

MDN Pages was recently merged.

Test results and supporting details

People reports that Safari 15.4 supports oklch().

I found mention only in Safari TP release notes.

@github-actions github-actions bot added the data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS label Jun 3, 2022
Copy link
Contributor

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there, thank you for your PR, and welcome to BCD!

Looking at the release notes you had linked, it appears to be for Safari Technology Preview (TP) 146. However, Safari 15.5 says that it includes TP 140-145, so I doubt this is correct. Let's set the version number to preview to say that it's only available in Safari Technology Preview!

@ai
Copy link
Contributor Author

ai commented Jun 4, 2022

Let me check the versions tomorrow

@ai
Copy link
Contributor Author

ai commented Jun 6, 2022

I tested oklch() in Safari 15.4 and it’s working.

Test: https://codepen.io/iskin/pen/OJQwEab

photo_2022-06-06_08-07-15

@romainmenke
Copy link
Contributor

romainmenke commented Jun 7, 2022

These are the relevant webkit release (137) notes mentioning oklab and oklch : https://webkit.org/blog/12156/release-notes-for-safari-technology-preview-137/

The link above includes all notes for all releases and 146 just happens to sit at the top at the moment :)

Copy link
Contributor

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, well alright then, guess you can't always trust release notes! Confirmed support in Safari 15.5 as well. Thank you for your PR, and once again, welcome to BCD! 👍

@ai
Copy link
Contributor Author

ai commented Jun 16, 2022

@queengooborg we still have No specification found and No compatibility data on MDN page for oklch().

https://developer.mozilla.org/en-US/docs/Web/CSS/color_value/oklch

Did I make some mistake? Or do we need to call deploy?

@queengooborg
Copy link
Contributor

You're all good! The problem is on our end -- due to a problem with the TypeScript type definitions, we're unable to update BCD in the MDN engine. We'll be fixing this as soon as possible, most likely within the next few days!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants