-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Add webextensions.api.tabGroups API
#26724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs). |
Rob--W
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved provided that the following changes are made.
To make it easier to see the result, I used the preview tool I created before, at https://jsbin.com/subipeyibo/edit?html,output
with the following URL as input: https://raw.githubusercontent.com/rebloor/browser-compat-data/Add-tabGroups-API/webextensions/api/tabGroups.json
webextensions/api/tabGroups.json
Outdated
| }, | ||
| "groupId": { | ||
| "__compat": { | ||
| "support": { | ||
| "chrome": { | ||
| "version_added": "89" | ||
| }, | ||
| "edge": "mirror", | ||
| "firefox": { | ||
| "version_added": "139" | ||
| }, | ||
| "firefox_android": { | ||
| "version_added": false | ||
| }, | ||
| "opera": "mirror", | ||
| "safari": { | ||
| "version_added": false | ||
| }, | ||
| "safari_ios": "mirror" | ||
| } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
webextensions.api.tabGroups.get.groupId does not need to be documented separately, as it is a core part of the API definition.
| }, | |
| "groupId": { | |
| "__compat": { | |
| "support": { | |
| "chrome": { | |
| "version_added": "89" | |
| }, | |
| "edge": "mirror", | |
| "firefox": { | |
| "version_added": "139" | |
| }, | |
| "firefox_android": { | |
| "version_added": false | |
| }, | |
| "opera": "mirror", | |
| "safari": { | |
| "version_added": false | |
| }, | |
| "safari_ios": "mirror" | |
| } | |
| } |
Co-authored-by: Rob Wu <[email protected]>
Summary
Adds data for the
webextensions.api.tabGroupsAPI and updates thepermissionsandoptional_permissionskey data for the introduction of thetabGroupspermission.Related issues
webextensions.api.tabGroupsdocumentation content#39370