Skip to content

Conversation

@jperelli
Copy link
Contributor

@jperelli jperelli commented May 7, 2025

Summary

RegExp.escape added to nodejs v24

Test results and supporting details

https://nodejs.org/en/blog/release/v24.0.0

@github-actions github-actions bot added data:js Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript size:xs [PR only] 0-6 LoC changed labels May 7, 2025
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Note that you'll also need to add a release entry in browsers/nodejs.json.

@caugner caugner changed the title RegExp.escape added to nodejs v24 Node.js 24 adds RegExp.escape May 7, 2025
@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2025

Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs).

@github-actions github-actions bot added data:browsers Data about browsers (versions, release dates, etc). This data is used for validation. size:s [PR only] 7-24 LoC changed size:m [PR only] 25-100 LoC changed data:wasm Compat data for Web Assembly features. https://developer.mozilla.org/en-US/docs/WebAssembly and removed size:xs [PR only] 0-6 LoC changed size:s [PR only] 7-24 LoC changed labels May 7, 2025
@jperelli jperelli changed the title Node.js 24 adds RegExp.escape Node.js 24 compat / notable changes May 7, 2025
@jperelli jperelli requested a review from caugner May 7, 2025 23:25
@jperelli jperelli requested a review from caugner May 7, 2025 23:37
},
"nodejs": {
"version_added": false
"version_added": "24.0.0"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nodejs/node#56497 similar to Safari below.

Copy link
Contributor Author

@jperelli jperelli May 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool thanks @zloirock , just added the same note, makes sense.

@caugner caugner changed the title Node.js 24 compat / notable changes Updates for Node.js 24.0 May 9, 2025
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, just nits regarding Error.isError() and Symbol.asyncDispose/dispose().

@jperelli jperelli requested a review from caugner May 9, 2025 12:46
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just one nit left: Can you copy over partial_implementation and notes to the earlier statement here (same for dispose())?

{
"version_added": "20.4.0",
"partial_implementation": true,
"notes": "Only available for `fs` and `stream` resources."
},
{
"version_added": "18.18.0",
"version_removed": "19.0.0"
}

Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

@caugner caugner merged commit 8395f1e into mdn:main May 9, 2025
6 checks passed
@mdn-bot mdn-bot mentioned this pull request May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data:browsers Data about browsers (versions, release dates, etc). This data is used for validation. data:js Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript data:wasm Compat data for Web Assembly features. https://developer.mozilla.org/en-US/docs/WebAssembly size:m [PR only] 25-100 LoC changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants