-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Updates for Node.js 24.0 #26735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates for Node.js 24.0 #26735
Conversation
caugner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
Note that you'll also need to add a release entry in browsers/nodejs.json.
|
Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs). |
Co-authored-by: Claas Augner <[email protected]>
Co-authored-by: Claas Augner <[email protected]>
javascript/builtins/Error.json
Outdated
| }, | ||
| "nodejs": { | ||
| "version_added": false | ||
| "version_added": "24.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nodejs/node#56497 similar to Safari below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool thanks @zloirock , just added the same note, makes sense.
caugner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, just nits regarding Error.isError() and Symbol.asyncDispose/dispose().
Co-authored-by: Claas Augner <[email protected]>
caugner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, just one nit left: Can you copy over partial_implementation and notes to the earlier statement here (same for dispose())?
browser-compat-data/javascript/builtins/Symbol.json
Lines 121 to 129 in 78e9489
| { | |
| "version_added": "20.4.0", | |
| "partial_implementation": true, | |
| "notes": "Only available for `fs` and `stream` resources." | |
| }, | |
| { | |
| "version_added": "18.18.0", | |
| "version_removed": "19.0.0" | |
| } |
caugner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM.
Summary
RegExp.escape added to nodejs v24
Test results and supporting details
https://nodejs.org/en/blog/release/v24.0.0