Skip to content

Conversation

@caugner
Copy link
Contributor

@caugner caugner commented May 13, 2025

Summary

Adds behavioral subfeature for Intl.Locale.getWeekInfo() returning minimalDays.

Test results and supporting details

Related issues

Fixes #26766.

@caugner caugner requested a review from Elchi3 May 13, 2025 18:04
@github-actions github-actions bot added data:js Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript size:m [PR only] 25-100 LoC changed labels May 13, 2025
@github-actions
Copy link
Contributor

Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs).

@Elchi3 Elchi3 merged commit 24a7fbc into main May 14, 2025
10 checks passed
@Elchi3 Elchi3 deleted the 26766-add-Intl-locale-getWeekInfo-minimalDays branch May 14, 2025 09:46
@mdn-bot mdn-bot mentioned this pull request May 14, 2025
},
"getWeekInfo": {
"__compat": {
"description": "`getWeekInfo()` method",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks weird. Virtually no method uses this kind of description—is that going to change en masse?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't look weird to me, and isn't uncommon: https://github.com/search?q=repo%3Amdn%2Fbrowser-compat-data%20%2F%20method%22%2F&type=code

What is your concern with this description?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing, it's just inconsistent with the majority which don't have descriptions. If methods are supposed to have descriptions like this (which I'm okay with) we should do that consistently.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick follow-up: We don't have plans to change this en masse. We probably want to add feature types at some point, so we can generate these at build time. Until then, adding descriptions manually makes the feature look slightly nicer in the BCD tables, with the risk of causing a line wrap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data:js Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript size:m [PR only] 25-100 LoC changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Intl.Locale.prototype.getWeekInfo() no longer includes minimalDays field

3 participants