-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Remove http.headers.Link.blocking #27145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This was implemented and has since been removed from the only browser that implemented it more than two years ago, and thus qualifies for removal per policy.
|
Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs). |
http/headers/Link.json
Outdated
| ], | ||
| "support": { | ||
| "chrome": { | ||
| "version_added": "105" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To make this easier to comprehend, and based on chromium/chromium@1d8c45a#diff-4b938e3a1dedc77093c5a2e3471fb2cb1c9c89e953fefc2394d9b27b65f8c91d and chromium/chromium@1372f23, could we first update this statement in the next release, and delete the statement only in the following release:
| "version_added": "105" | |
| "version_added": "103", | |
| "version_removed": "105" |
/cc @ddbeck
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it'd be nice for the blame to show this—so there's two commits for it. But it does meet the guidelines, so it's OK if it all happens in the same release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Daniel. Let's do this then!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gsnedders I'll open a PR with the change above, and then we just need to rebase this one later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That PR is merged, but I would prefer to have Chrome's removal in the published BCD version before preceeding with removing the feature altogether.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting round to this before I had a moment!
Summary
This removes
http.headers.Link.blocking.Test results and supporting details
Unfortunately the tests for this were removed from WPT in web-platform-tests/wpt#34083. I've filed a draft PR with these reverted in web-platform-tests/wpt#53403 to demonstrate lack of support, but results are yet to appear on wpt.fyi as of writing.
Support for
render=blockingon alinkelement was removed in whatwg/html@448f240, and whatwg/html@0ea88cf clarified whichlinkthings were also valid in theLinkheader.These were both removed from Chromium in chromium/chromium@1372f23, and the earliest tag containing this is 104.0.5074.0. Chrome 104 shipped Tue, Aug 2, 2022 per https://chromiumdash.appspot.com/schedule.
Thus, per the guidelines the "a feature was implemented and has since been removed from all browsers dating back two or more years ago" criteria is met and this feature can be removed.
Related issues
Fixes #26880.
See also web-platform-dx/web-features#3077.