webextension.api add missing __compat objects
#27203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebloor
added
the
data:webext
Contributor
|
Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs). |
dotproto
reviewed
Jul 2, 2025
Contributor
dotproto
left a comment
dotproto
left a comment
There was a problem hiding this comment.
I dug into the history of toProxyScript(). It appears that this method was removed from Firefox about 7 years ago as part of bug 1443259. See Comment 15 for a mention of removing related documentation from MDN.
Contributor
Author
|
Thanks @dotproto thinking that I didn't find this because I forgot to search the comments! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change adds missing
__compatobjects to the path of several web extension API features.This was done for two reasons:
The definition of the scheme of states that "identifiers without __compat aren't necessarily features". The items affected in this PR are features.
It resolves some presentation issues. For example, take the example of
browsingData.DataTypeSet:browsingData,DataTypeSetis not listed.DataTypeSetthe properties are listed, however, the first property has a link back to the page, rather than the link being onDataTypeSet.Note. Removed
runtime.sendMessage.options.toProxyScriptas it's not mentioned in the runtime schema, documented on MDM, or mentioned in any item.